-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Grammar for codecov comment when missing coverage #481
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 443 443
Lines 34851 34853 +2
=======================================
+ Hits 33908 33910 +2
Misses 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34122 34124 +2
=======================================
+ Hits 33189 33191 +2
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34122 34124 +2
=======================================
+ Hits 33189 33191 +2
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 412 412
Lines 34122 34124 +2
=======================================
+ Hits 33189 33191 +2
Misses 933 933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Removes the "are" when missing lines of coverage.
Also adds a conditional where if there's only 1 line uncovered we say "line" instead of "lines"
Old:
Attention: Patch coverage is 97.53086% with 2 lines in your changes are missing coverage. Please review.
New:
Attention: Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.